rename OnDisconnect to OnDisconnected to match parent method#725
Merged
anunaym14 merged 1 commit intolivekit:mainfrom Aug 27, 2025
Merged
rename OnDisconnect to OnDisconnected to match parent method#725anunaym14 merged 1 commit intolivekit:mainfrom
anunaym14 merged 1 commit intolivekit:mainfrom
Conversation
|
|
Member
|
Thanks for flagging this, it is a public API change that I'd be reluctant to merge because it can break things for end users. Though, I'll make a note of this and make things consistent whenever we do the next major version upgrade for the SDK! |
anunaym14
approved these changes
Aug 27, 2025
Member
anunaym14
left a comment
anunaym14
left a comment
There was a problem hiding this comment.
Oops, this actually got changed recently, fixing it and doing another tagged release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed Room method from OnDisconnect to OnDisconnected